-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppetlabs apache dependency #11
base: master
Are you sure you want to change the base?
Puppetlabs apache dependency #11
Conversation
BTW, I have updated the documentation and version number in my master branch... did not want to send you yet-another PR. |
Why did you change your "allow" parameter from an array to a single string? |
Ah... that! |
Could you maybe change it back to an array, to not break the existing parameter values, and simply use the stdlib |
It also seems there are references to apache_httpd as type rather than a class making the nagios::server code completely broken. |
This is quite old and Thias has moved forward... I will merge with the newest and submit the PR again, but it will take me some time. |
You're probably using my apache_httpd module master branch from git, since the latest published forge version is still a definition. Adapting for the newer class is trivial, and will be done once I update my forge module to be a class. |
Dear Thias,
I have been strugling to send you a set of pull requests, one for each important feature that I contributed, and it was impossible. Therefore, I am afraid I have to send all together into one single super-pull-request... sorry about that.
There are a few changes that are trivial, specially the first 5 commits (oldest).
The next 5 commits correspond to the feature "remote checks", that is quite interesting to have other modules define their own checks, while leaving the nagios module alone. I would like to migrate all existing checks to this "new schema" some day soon.
And the last commits are for another feature: puppetlabs-apache dependency. I put all your thias/apache dependencies into one big IF, and added a second big IF with the puppetlabs one. Hope you like it.
Have a good weekend!